Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Korean translation for docs/ko/docs/advanced/advanced-dependencies.md#12675

Merged
alejsdev merged 14 commits into
fastapi:masterfrom
kim-sangah:features/ko-advanced-advanced-dependencies
Nov 7, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/advanced/advanced-dependencies.md#12675
alejsdev merged 14 commits into
fastapi:masterfrom
kim-sangah:features/ko-advanced-advanced-dependencies

Conversation

@kim-sangah

Copy link
Copy Markdown
Contributor

Add translation to docs/ko/docs/advanced/advanced-dependencies.md

@github-actions github-actions Bot added the lang-all Translations label Oct 28, 2024
@github-actions

Copy link
Copy Markdown
Contributor

@kim-sangah kim-sangah changed the title Add translation to docs/ko/docs/advanced/advanced-dependencies.md 🌐Add translation to docs/ko/docs/advanced/advanced-dependencies.md Oct 28, 2024
@kim-sangah kim-sangah changed the title 🌐Add translation to docs/ko/docs/advanced/advanced-dependencies.md 🌐Add translation to docs/ko/docs/advanced/advanced-dependencies.md Oct 28, 2024
@alejsdev alejsdev changed the title 🌐Add translation to docs/ko/docs/advanced/advanced-dependencies.md 🌐Add Korean translation for docs/ko/docs/advanced/advanced-dependencies.md Oct 28, 2024
@alejsdev alejsdev added lang-ko Korean translations awaiting-review labels Oct 28, 2024

@JaeHyuckSa JaeHyuckSa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! @kim-sangah, thank you for your contribute. 👍 There are a few revisions needed. (Related issue: #2017)

Comment thread docs/ko/docs/advanced/advanced-dependencies.md Outdated
Comment thread docs/ko/docs/advanced/advanced-dependencies.md Outdated
Comment thread docs/ko/docs/advanced/advanced-dependencies.md Outdated
Comment thread docs/ko/docs/advanced/advanced-dependencies.md Outdated
Comment thread docs/ko/docs/advanced/advanced-dependencies.md Outdated
Comment thread docs/ko/docs/advanced/advanced-dependencies.md Outdated
Comment thread docs/ko/docs/advanced/advanced-dependencies.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev changed the title 🌐Add Korean translation for docs/ko/docs/advanced/advanced-dependencies.md 🌐 Add Korean translation for docs/ko/docs/advanced/advanced-dependencies.md Oct 29, 2024

@alejsdev alejsdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kim-sangah, thanks for your interest in contributing to FastAPI.
However, I've noticed an error in the preview:

image

You can see the translations guidelines for more information here:
https://fastapi.tiangolo.com/contributing/#translations

Thanks!

Comment thread docs/ko/docs/advanced/advanced-dependencies.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@kim-sangah kim-sangah requested a review from alejsdev October 31, 2024 08:40

@alejsdev alejsdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now! Thanks 🤓

@alejsdev alejsdev merged commit 321053b into fastapi:master Nov 7, 2024
@alejsdev

alejsdev commented Nov 7, 2024

Copy link
Copy Markdown
Member

Thanks for your contribution! 😄 @kim-sangah
And thanks for your review 🤓 @JaeHyuckSa

@kim-sangah kim-sangah deleted the features/ko-advanced-advanced-dependencies branch November 8, 2024 02:26
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants