Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Portuguese translation for docs/pt/docs/advanced/openapi-callbacks.md#12705

Merged
alejsdev merged 4 commits into
fastapi:masterfrom
devfernandoa:pt-translation-openapi-callbacks
Oct 30, 2024
Merged

🌐 Add Portuguese translation for docs/pt/docs/advanced/openapi-callbacks.md#12705
alejsdev merged 4 commits into
fastapi:masterfrom
devfernandoa:pt-translation-openapi-callbacks

Conversation

@devfernandoa

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the lang-all Translations label Oct 28, 2024
@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev added lang-pt Portuguese translations awaiting-review labels Oct 28, 2024
@alejsdev alejsdev changed the title 🌐 Add Portuguese translation for docs/pt/docs/how-to/openapi-callbacks.md 🌐 Add Portuguese translation for docs/pt/docs/how-to/openapi-callbacks.md Oct 28, 2024
@nazarepiedady

Copy link
Copy Markdown
Contributor

@devfernandoa, normally, it is recommended to only modify one single file per pull request, but I think in this one, we could benefit from an exception.

Keep following this path of collaborating with open-source initiatives.

@nazarepiedady

Copy link
Copy Markdown
Contributor

@ceb10n and @cassiobotaro, could you do the kindness of reviewing this pull request?

@tiangolo

Copy link
Copy Markdown
Member

@devfernandoa please separate this in 2 PRs, one for each file, this way it will be easier to review. 🤓☕

@nazarepiedady I'll ask you to please don't give instructions about managing the PRs or the repo, those things would be decided by someone in the FastAPI team, and getting external instructions could be confusing for people contributing. Also there's no need to ping others. Thanks!

@devfernandoa

Copy link
Copy Markdown
Contributor Author

Sorry guys, I forgot to remove the file when switching branches.
Fixed it here, and the other PR is already open as well!

@github-actions

Copy link
Copy Markdown
Contributor

@ceb10n ceb10n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @devfernandoa

Just some lines that need to be removed, and some minor suggestions 😄


* Enviar uma solicitação de pagamento para o desenvolvedor externo.
* Coletar o dinheiro.
* Send a notification back to the API user (the external developer).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've forgotten to remove this line 😄

{!../../docs_src/openapi_callbacks/tutorial001.py!}
```

/// tip | dica

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a silly suggestion:

We alway start with a capital letter the translation of the admonitions


///

The only new thing is the `callbacks=invoices_callback_router.routes` as an argument to the *path operation decorator*. We'll see what that is next.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line to :D


Esse exemplo não implementa o callback em si (que poderia ser apenas uma linha de código), apenas a parte da documentação.

/// tip | dica

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here to, just start with a capital letter if you want :D


O callback real é apenas uma solicitação HTTP.

When implementing the callback yourself, you could use something like <a href="https://www.python-httpx.org" class="external-link" target="_blank">HTTPX</a> or <a href="https://requests.readthedocs.io/" class="external-link" target="_blank">Requests</a>.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs to be removed to


Então vamos usar esse mesmo conhecimento para documentar como a *API externa* deveria ser... criando as *operações de rota* que a *API externa* deveria implementar (as que sua API irá chamar).

/// tip | dica

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here to, just start with a capital letter if you want :D

}
```

/// tip | dica

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here to, just start with a capital letter if you want :D

{!../../docs_src/openapi_callbacks/tutorial001.py!}
```

/// tip | dica

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here to, just start with a capital letter if you want :D

@ceb10n

ceb10n commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

Not a so important thing that I've noticed:

The title is incorrect: this file lives under advanced, not how-to

@devfernandoa devfernandoa changed the title 🌐 Add Portuguese translation for docs/pt/docs/how-to/openapi-callbacks.md 🌐 Add Portuguese translation for docs/pt/docs/advanced/openapi-callbacks.md Oct 30, 2024
@devfernandoa

Copy link
Copy Markdown
Contributor Author

Just fixed these changes, thanks for the review @ceb10n !

@github-actions

Copy link
Copy Markdown
Contributor

@ceb10n ceb10n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗

@alejsdev alejsdev merged commit 5be5ea9 into fastapi:master Oct 30, 2024
@alejsdev

Copy link
Copy Markdown
Member

Thank you for being so interested in contributing to FastAPI! @devfernandoa 🤓

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-pt Portuguese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants