Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Korean translation for docs/ko/docs/advanced/using_request_directly.md#12738

Merged
alejsdev merged 4 commits into
fastapi:masterfrom
kwang1215:features/ko-advanced-using_request_directly
Nov 7, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/advanced/using_request_directly.md#12738
alejsdev merged 4 commits into
fastapi:masterfrom
kwang1215:features/ko-advanced-using_request_directly

Conversation

@kwang1215

Copy link
Copy Markdown
Contributor

Add Korean translation for docs/ko/docs/advanced/using_request_directly.md

@github-actions github-actions Bot added the lang-all Translations label Nov 1, 2024
@github-actions

github-actions Bot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Nov 1, 2024

@BORA040126 BORA040126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의견 검토해 주시면 감사하겠습니다.

Comment thread docs/ko/docs/advanced/using-request-directly.md Outdated
@github-actions

github-actions Bot commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

@kwang1215 kwang1215 requested a review from BORA040126 November 4, 2024 11:19

*경로 작동 함수* 매개변수를 `Request` 타입으로 선언하면 **FastAPI**가 해당 매개변수에 `Request` 객체를 전달하는 것을 알게 됩니다.

/// tip "팁"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷 2024-11-05 115613
스크린샷 2024-11-05 115547

영문문서와 다르게 표시되어 보이는 것 같아서 한 번 찾아보겠습니다

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge 되면 제대로 보일지 원리를 잘 모르겠어서

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note | "Technical Details"
혹시 그 부분을 | 를 이용해서 컨벤션을 맞춰보실 수 있으신가요?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

말씀해주셔서 감사합니다. 말씀 주신 대로 수정하였습니다!

@github-actions

github-actions Bot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

@9zimin9

9zimin9 commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

LGTM!

@BORA040126 BORA040126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🔥

@Limsunoh

Limsunoh commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

LGTM 🚀

@alejsdev alejsdev merged commit c5ff950 into fastapi:master Nov 7, 2024
@alejsdev

alejsdev commented Nov 7, 2024

Copy link
Copy Markdown
Member

Thanks for your help! @kwang1215 🤓
And thanks for your reviews @BORA040126 @9zimin9 @Limsunoh 🎉

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants