Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Ukrainian translation for docs/uk/docs/tutorial/query-params.md#13362

Merged
tiangolo merged 5 commits into
fastapi:masterfrom
valentinDruzhinin:translate-uk/query-params
Feb 28, 2025
Merged

🌐 Add Ukrainian translation for docs/uk/docs/tutorial/query-params.md#13362
tiangolo merged 5 commits into
fastapi:masterfrom
valentinDruzhinin:translate-uk/query-params

Conversation

@valentinDruzhinin

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the lang-all Translations label Feb 12, 2025
@github-actions

Copy link
Copy Markdown
Contributor

@svlandeg svlandeg changed the title Add ukrainian translation for query-params 🌐 Add Ukrainian translation for docs/uk/docs/tutorial/query-params.md Feb 18, 2025
@svlandeg

Copy link
Copy Markdown
Member

Hi @SofiiaTrufanova and @DianaTrufanova,

thanks for reviewing these translation PRs! It would be helpful if you could add a bit of context on what exactly you reviewed, whether you are a native UK speaker or not, and whether or not you checked that all the content on the English page is accurately reflected in this translation. Just a quick "approved" unfortunately does not tell us much about the way you've reviewed, and generally it would also suprise me if there are always zero review comments (feel free to nitpick a bit!).

@SofiiaTrufanova

Copy link
Copy Markdown

Hi! @svlandeg I reviewed the translation from the English version to Ukrainian cause I'm a native speaker of Ukrainian and all is fine in that translation and nothing needs to be added

@alejsdev alejsdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a formatting nitpick 😅

Comment thread docs/uk/docs/tutorial/query-params.md Outdated
@DianaTrufanova

Copy link
Copy Markdown

Hi @svlandeg,
I'm a native Ukrainian speaker and after reviewing the translation everything is correct for me. All the content is accurately translated from English to Ukrainian.

@github-actions

Copy link
Copy Markdown
Contributor

@rostik1410

Copy link
Copy Markdown
Contributor

@valentinDruzhinin great work (as in all other PRs) Could you pls replace all ви and other forms of this word with Ви. I will not request changes here because this PR already has 2 approvs and those changes are not critical. But would we cool

@valentinDruzhinin valentinDruzhinin force-pushed the translate-uk/query-params branch from bf8614b to bbde217 Compare February 18, 2025 22:06
@github-actions

Copy link
Copy Markdown
Contributor

@svlandeg svlandeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from a structural point of view! 🥳

Comment thread docs/uk/docs/tutorial/query-params.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

@tiangolo tiangolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @valentinDruzhinin! 🍪

And thanks for the help and reviews @svlandeg, @alejsdev, @rostik1410, @SofiiaTrufanova, @DianaTrufanova

@tiangolo tiangolo merged commit 23821e9 into fastapi:master Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-uk Ukrainian translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants