Thanks to visit codestin.com
Credit goes to github.com

Skip to content

upgrade starlette dependency to 0.13.4#1361

Merged
tiangolo merged 1 commit into
fastapi:masterfrom
rushton:upgrade_starlette
Jun 13, 2020
Merged

upgrade starlette dependency to 0.13.4#1361
tiangolo merged 1 commit into
fastapi:masterfrom
rushton:upgrade_starlette

Conversation

@rushton

@rushton rushton commented May 1, 2020

Copy link
Copy Markdown
Contributor

This upgrade is mostly to address the issue with StreamingResponse not killing the request when the client unexpectedly disconnects from the stream.

@codecov

codecov Bot commented May 1, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          226       226           
  Lines         6785      6785           
=========================================
  Hits          6785      6785           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e77737...d840d96. Read the comment docs.

@mumumumu

Copy link
Copy Markdown

This is also needed to support the SameSite flag when setting cookies (mentioned in #1099 and #480).

@victoraugustolls

Copy link
Copy Markdown

@tiangolo is this ok? Really looking forward to use newest starlette version for the fixes.

@ziglef

ziglef commented May 26, 2020

Copy link
Copy Markdown

If this is ok, I'm also looking forward to use the newest starlette version (mostly for samesite cookies)

@euri10

euri10 commented Jun 6, 2020

Copy link
Copy Markdown
Contributor

If this is ok, I'm also looking forward to use the newest starlette version (mostly for samesite cookies)

same !

@tiangolo tiangolo merged commit 9aea85a into fastapi:master Jun 13, 2020
@tiangolo

Copy link
Copy Markdown
Member

Great! Thank you @rushton ! 🚀

This will be available in FastAPI version 0.57.0, (to be released in a couple of hours).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants