Added test for repeating cookies in response headers#1385
Closed
scottsmith2gmail wants to merge 1 commit into
Closed
Added test for repeating cookies in response headers#1385scottsmith2gmail wants to merge 1 commit into
scottsmith2gmail wants to merge 1 commit into
Conversation
Contributor
|
the problem is that a call to one obvious solution that comes to mind is to check whether |
Member
|
Thanks for discovering this and creating the tests @scottsmith2gmail ! 🕵️ 🐛 ✔️ I just merged the fix by @obataku including your tests, so we can close this one. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this issue using fastapi. I haven't tracked down the cause. It seems every additional layer of redirection doubles the cookies in the header. No clue if this would actually break anything, but it seems like incorrect behavior at any rate.