Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

HUDA-GIF
Copy link

This PR fixes an issue where ExampleModel had an incorrect default value.
Changes:

  • Made field_1 optional
  • Added test to validate behavior

@HUDA-GIF
Copy link
Author

Hi there πŸ‘‹,
I’ve submitted this PR to fix the ExampleModel default value bug and added a passing test to cover it.
Everything is formatted and ready for review βœ….

Would love a quick review or approval for the workflows to run when you have a moment.
Thanks so much for your time and for maintaining this awesome project! πŸ™Œ

1 similar comment
@HUDA-GIF

This comment was marked as duplicate.

@sneakers-the-rat
Copy link

sneakers-the-rat commented Aug 27, 2025

this both fixes nothing (it touches 0 lines of the package code) and misses the point of the issue. None is a special case, the test fails if the default is anything but None, which is the problem.

recommend close as spam

@svlandeg svlandeg added the bug Something isn't working label Aug 28, 2025
@svlandeg svlandeg marked this pull request as draft August 28, 2025 09:14
@svlandeg svlandeg changed the title Fix ExampleModel default value bug and add passing test πŸ› Fix ExampleModel default value bug and add passing test Aug 28, 2025
@svlandeg
Copy link
Member

@HUDA-GIF : thanks for your interest in contributing to FastAPI!

So far, this PR only contains a failing test. Did you forget to commit something?

@sneakers-the-rat
Copy link

for context, raised against this issue, which already has a PR in place and has half a dozen automated-seeming replies at the bottom pitching semi-sensical fixes to it despite the surrounding comments saying "it's already been done" which is why i thought this was spam. sorry if that sounded harsh out of context - #13399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants