⚡️ Reuse coroutine inspection result#14291
Closed
dolfinus wants to merge 1 commit into
Closed
Conversation
YuriiMotov
approved these changes
Nov 5, 2025
YuriiMotov
left a comment
Member
There was a problem hiding this comment.
LGTM!
@dolfinus, thank you!
Before:
$ python perf.py
Called get_route_handler() 50,000,000 times in 49.6951s
Average per call: 0.99 µs
After:
$ python perf.py
Called get_route_handler() 50,000,000 times in 31.5395s
Average per call: 0.63 µs
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
Contributor
Author
|
Implemented by #14434 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14262 implemented caching of
inspectmodule calls withinDependantclass, but it left one clause outside, and it is called on every request.Reusing
inspect.iscoroutinefunctionresult reduces time spent inget_route_handlerfrom 2.23 µs to 1.33 µs:perf.py
Before:

After:
