Set dependant security scopes if dependency_overrides is set#1549
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 227 236 +9
Lines 6810 7053 +243
==========================================
+ Hits 6810 7053 +243
Continue to review full report at Codecov.
|
dependency_overrides is set
Member
|
Awesome! Great job finding the fix! 🐛 🕵️ 🔍 I just added tests for it and we're now good to go 👌 Thanks for your contribution! 🚀 🍰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change follows the precedent of https://github.com/tiangolo/fastapi/blob/master/fastapi/dependencies/utils.py#L152
Alternatively,
security_scopescould be set withinget_dependant(within theDependantconstructor).This should fix/related to #737