Thanks to visit codestin.com
Credit goes to github.com

Skip to content

✅ Update tests, don't double dispose the engine#15587

Merged
tiangolo merged 1 commit into
masterfrom
engine-dispose
May 23, 2026
Merged

✅ Update tests, don't double dispose the engine#15587
tiangolo merged 1 commit into
masterfrom
engine-dispose

Conversation

@tiangolo

Copy link
Copy Markdown
Member

Pull Request

Discussion:

Description

Fix engine dispose duplicate from tests, pointed out in #13583 (comment)

AI Disclaimer

AI transcript

Checklist

  • This PR is an obvious typo fix, or it links to a GitHub Discussion for the proposed code change.
  • I added tests for the change.
  • The new or updated tests fail on the main branch and pass on this PR.
  • Coverage stays at 100%.
  • The documentation explains the change if needed.

@tiangolo tiangolo marked this pull request as ready for review May 23, 2026 16:56
@tiangolo tiangolo enabled auto-merge (squash) May 23, 2026 16:56
@tiangolo tiangolo merged commit 00f805c into master May 23, 2026
42 of 44 checks passed
@tiangolo tiangolo deleted the engine-dispose branch May 23, 2026 17:02
@codspeed-hq

codspeed-hq Bot commented May 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

🎉 Hooray! pytest-codspeed just leveled up to 4.4.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

✅ 20 untouched benchmarks


Comparing engine-dispose (8770390) with master (6cbdde2)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (3675137) during the generation of this report, so 6cbdde2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant