Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for tutorial/index.md#1656

Merged
tiangolo merged 16 commits into
fastapi:masterfrom
tokusumi:translation/japanese-tutorial-index-md
Oct 17, 2020
Merged

🌐 Add Japanese translation for tutorial/index.md#1656
tiangolo merged 16 commits into
fastapi:masterfrom
tokusumi:translation/japanese-tutorial-index-md

Conversation

@tokusumi

@tokusumi tokusumi commented Jun 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR translates the tutorial/index.md to Japanese.
Please review tutorial/index.md.

Issue #1571 generates a new directory to support Japanese.
I will fix dependency after #1571 is merged.

@codecov

codecov Bot commented Jun 30, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1656 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1656   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db91255...826154b. Read the comment docs.

@tokusumi tokusumi mentioned this pull request Jun 30, 2020
Closed
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Jul 3, 2020
@github-actions

github-actions Bot commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit cedd872 at: https://5f37d177469979a705135591--fastapi.netlify.app

SwftAlpc
SwftAlpc suggested changes Aug 15, 2020
View reviewed changes

@SwftAlpc SwftAlpc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an almost perfect translation. Thank you.
I have added and corrected some of the missing parts.
Please check.

Comment thread docs/ja/docs/tutorial/index.md Outdated
Comment thread docs/ja/docs/tutorial/index.md Outdated
Comment thread docs/ja/docs/tutorial/index.md Outdated
Comment thread docs/ja/docs/tutorial/index.md Outdated
Comment thread docs/ja/docs/tutorial/index.md Outdated
pip install fastapi
```

Also install `uvicorn` to work as the server:

@SwftAlpc SwftAlpc Aug 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

また、サーバーとして動作するようにuvicornをインストールします。

Comment thread docs/ja/docs/tutorial/index.md Outdated
Comment thread docs/ja/docs/tutorial/index.md Outdated
SwftAlpc
SwftAlpc approved these changes Aug 15, 2020
View reviewed changes

@SwftAlpc SwftAlpc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!�
Thanks for the quick response!

@github-actions

github-actions Bot commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit f5154a5 at: https://5f38171bfb8f78e941f53949--fastapi.netlify.app

This was referenced Aug 16, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 21, 2020
Merged
Merged
ryuckel
ryuckel approved these changes Aug 21, 2020
View reviewed changes

@ryuckel ryuckel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread docs/ja/docs/tutorial/index.md
Comment thread docs/ja/docs/tutorial/index.md Outdated
Comment thread docs/ja/docs/tutorial/index.md Outdated
Comment thread docs/ja/docs/tutorial/index.md Outdated
Comment thread docs/ja/docs/tutorial/index.md Outdated
This was referenced Aug 21, 2020
Merged
Closed
Merged
@github-actions

github-actions Bot commented Aug 22, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit c990f9c at: https://5f409b0aa293b73dea4a98ff--fastapi.netlify.app

This was referenced Aug 23, 2020
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
@github-actions

github-actions Bot commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 4bb7ce6 at: https://5f4a707b302549f94074854a--fastapi.netlify.app

@tokusumi

tokusumi commented Sep 26, 2020

Copy link
Copy Markdown
Contributor Author

Hi, @tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

@komtaki komtaki mentioned this pull request Oct 10, 2020
Merged
@tiangolo tiangolo changed the title Add Japanese translation for tutorial/index.md 🌐 Add Japanese translation for tutorial/index.md Oct 17, 2020
@tiangolo tiangolo merged commit b6272a3 into fastapi:master Oct 17, 2020
@tiangolo

tiangolo commented Oct 17, 2020

Copy link
Copy Markdown
Member

Awesome! Thank you @tokusumi 🙇 ☕

And thanks @ryuckel and @SwftAlpc for the reviews! 👏 🤓

@tokusumi tokusumi deleted the translation/japanese-tutorial-index-md branch January 18, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ryuckel ryuckel ryuckel approved these changes

@SwftAlpc SwftAlpc SwftAlpc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tokusumi @tiangolo @ryuckel @SwftAlpc