-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Update isort script to match changes in the new release, isort v5.0.2 #1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c84ea7f
41d847b
909282b
f1a4a10
eb2a26e
b60d64b
d77812f
f0d5116
019bde4
919ad82
e2e2920
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| from fastapi.testclient import TestClient | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't want to use isort in this tutorial, because
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this supposed to be in all the tutorials? If so, I can tell isort to ignore the files.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think all of them use fastapi as third party... If that's true, yes.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's correct. I've made adjustment in the new isort configuration file. This should be flexible. |
||
|
|
||
| from additional_responses.tutorial001 import app | ||
| from docs_src.additional_responses.tutorial001 import app | ||
|
|
||
| client = TestClient(app) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to use isort in this tutorial, because
fastapiandpydanticare really third party imports here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed