Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for tutorial/path-params.md#1671

Merged
tiangolo merged 15 commits into
fastapi:masterfrom
tokusumi:translation/add-japanese-tutorial-path-params
Oct 17, 2020
Merged

🌐 Add Japanese translation for tutorial/path-params.md#1671
tiangolo merged 15 commits into
fastapi:masterfrom
tokusumi:translation/add-japanese-tutorial-path-params

Conversation

@tokusumi

@tokusumi tokusumi commented Jul 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR translates the tutorial/path-params.md to Japanese.
Please review tutorial/path-params.md

Issue #1571 generates a new directory to support Japanese.
I will fix dependency after #1571 is merged.

@tokusumi tokusumi mentioned this pull request Jul 5, 2020
Closed
@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations awaiting-review labels Jul 10, 2020
@codecov

codecov Bot commented Aug 15, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1671   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d76700...5413ee4. Read the comment docs.

@github-actions

github-actions Bot commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 4d7a4e5 at: https://5f37deb8fded4343d1946d7e--fastapi.netlify.app

SwftAlpc
SwftAlpc suggested changes Aug 15, 2020
View reviewed changes

@SwftAlpc SwftAlpc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation!
We need to make some corrections.
Please check.

Comment thread docs/ja/docs/tutorial/path-params.md Outdated
Comment thread docs/ja/docs/tutorial/path-params.md Outdated
Comment thread docs/ja/docs/tutorial/path-params.md Outdated
Comment thread docs/ja/docs/tutorial/path-params.md
Comment thread docs/ja/docs/tutorial/path-params.md Outdated
Comment thread docs/ja/docs/tutorial/path-params.md
Comment thread docs/ja/docs/tutorial/path-params.md Outdated
Comment thread docs/ja/docs/tutorial/path-params.md
Comment thread docs/ja/docs/tutorial/path-params.md Outdated
@github-actions

github-actions Bot commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 3a9a218 at: https://5f38171b469979b51113539e--fastapi.netlify.app

SwftAlpc
SwftAlpc approved these changes Aug 15, 2020
View reviewed changes

@SwftAlpc SwftAlpc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ryuckel
ryuckel approved these changes Aug 21, 2020
View reviewed changes

@ryuckel ryuckel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tokusumi
Merge branch 'master' of https://github.com/tokusumi/fastapi into tra…
fdecb70 
…nslation/add-japanese-tutorial-path-params
@github-actions

github-actions Bot commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit fdecb70 at: https://5f4a7079281ab6fafb5f5d35--fastapi.netlify.app

@tokusumi

tokusumi commented Sep 26, 2020

Copy link
Copy Markdown
Contributor Author

Hi, @tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

@tiangolo tiangolo changed the title Add Japanese translation for tutorial/path-params.md 🌐 Add Japanese translation for tutorial/path-params.md Oct 17, 2020
@tiangolo

tiangolo commented Oct 17, 2020

Copy link
Copy Markdown
Member

This is amazing! Thanks for all the work you have been doing with this @tokusumi ! 👏 👏 🙇 ☕

And thanks @ryuckel and @SwftAlpc for the reviews! 🍰 🤓

@tiangolo tiangolo merged commit 4530456 into fastapi:master Oct 17, 2020
@tokusumi tokusumi deleted the translation/add-japanese-tutorial-path-params branch January 18, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ryuckel ryuckel ryuckel approved these changes

@SwftAlpc SwftAlpc SwftAlpc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tokusumi @tiangolo @ryuckel @SwftAlpc