Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add external link to starlette documentation for further details#1717

Merged
tiangolo merged 3 commits into
fastapi:masterfrom
hellocoldworld:patch-1
Aug 3, 2020
Merged

Add external link to starlette documentation for further details#1717
tiangolo merged 3 commits into
fastapi:masterfrom
hellocoldworld:patch-1

Conversation

@hellocoldworld

Copy link
Copy Markdown
Contributor

No description provided.

Add external link to starlette documentation for further details
@codecov

codecov Bot commented Jul 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1717 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1717    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          238       235     -3     
  Lines         7187      6987   -200     
==========================================
- Hits          7187      6987   -200     
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
fastapi/utils.py
fastapi/__init__.py
tests/utils.py
tests/main.py
tests/test_get_request_body.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60dd1b...8014b5f. Read the comment docs.

@Kludex Kludex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think adding a note about it?

Comment thread docs/en/docs/advanced/testing-websockets.md Outdated
Comment thread docs/en/docs/advanced/testing-websockets.md Outdated
Co-authored-by: Marcelo Trylesinski <[email protected]>
@tiangolo tiangolo merged commit d1585c4 into fastapi:master Aug 3, 2020
@tiangolo

tiangolo commented Aug 3, 2020

Copy link
Copy Markdown
Member

Good idea, thanks @hellocoldworld ! 🍰

And thanks @Kludex for the help! ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants