Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add French translation for index.md#1973

Closed
JulianMaurin wants to merge 6 commits into
fastapi:masterfrom
JulianMaurin:feat/translation-fr-index
Closed

Add French translation for index.md#1973
JulianMaurin wants to merge 6 commits into
fastapi:masterfrom
JulianMaurin:feat/translation-fr-index

Conversation

@JulianMaurin

@JulianMaurin JulianMaurin commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

Hello 👋

This is a PR to translate docs/index.md to french 🇫🇷

According to the issue: #1972

Saving you some clicks:

  • the formatted document: here
  • the diff from English: here

Thanks 👽

@codecov

codecov Bot commented Aug 26, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1973 (2106e4c) into master (e35df68) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1973   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13684     13684           
=========================================
  Hits         13684     13684           
Impacted Files Coverage Δ
fastapi/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50fb34b...2106e4c. Read the comment docs.

@JulianMaurin JulianMaurin force-pushed the feat/translation-fr-index branch 2 times, most recently from 2e27897 to 1c22c96 Compare August 26, 2020 07:34
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 1c22c9683295482146565bcdafb959ac3ea3b876 at: https://5f46199400610924347650bb--fastapi.netlify.app

@Kludex

Kludex commented Aug 26, 2020

Copy link
Copy Markdown
Member

@JulianMaurin I suggest you to create a separate MR for the initial language setup. This was done on the other languages because the setup itself doesn't need a French speaker as reviewer and it can be merged faster.

@ghost ghost mentioned this pull request Aug 26, 2020
@ghost

ghost commented Aug 26, 2020

Copy link
Copy Markdown

@JulianMaurin I suggest you to create a separate MR for the initial language setup. This was done on the other languages because the setup itself doesn't need a French speaker as reviewer and it can be merged faster.

Hey @Kludex, thanks for your feedback.
Here is the PR: #1975

@tiangolo tiangolo added awaiting-review lang-all Translations lang-fr French translations labels Aug 29, 2020
@ghost

ghost commented Sep 11, 2020

Copy link
Copy Markdown

Thanks to Development - Contributing' guidelines:

  1. Translation is correct for me ( Thx Julian ;) )
  2. Translation can be merged! ( Thx to FastAPI Team ;) )

Thanks in advance.

@JulianMaurin JulianMaurin force-pushed the feat/translation-fr-index branch from 1c22c96 to e59e2f0 Compare October 4, 2020 14:30
@github-actions

github-actions Bot commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit e59e2f0 at: https://5f79e684684027c1fbceaba1--fastapi.netlify.app

@JulianMaurin JulianMaurin changed the title Add French translation for tutorial/index.md Add French translation for index.md Oct 5, 2020
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
Comment thread docs/fr/docs/index.md Outdated
@jburckel

Copy link
Copy Markdown

Hi,

Thank you for the great work!
I've made some suggestions to the text. I hope it was the right method 😅 and that it will be useful.

There is still missing space after colon ponctuation, like for example line 36 to 42. But I think I've already made too much suggestions.
I would also be favorable to put a space after the three dots as in the expression '... de' (line 383). But I wasn't sure at 100%...

I would like to contribute from time to time. Let me know what the best method to help when reviewing the translation.

Thanks!

@JulianMaurin JulianMaurin force-pushed the feat/translation-fr-index branch from e59e2f0 to 4a4c1c2 Compare July 16, 2022 20:49
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 3145273 at: https://62d325677fc77351ad174235--fastapi.netlify.app

@JulianMaurin JulianMaurin left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

Thanks a lot for the great reviews. I'm taking everything 🚀

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit fe9737d at: https://62d329558083e155772ea969--fastapi.netlify.app

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 93475d2 at: https://62d32fa481fa5c5b79b8a7d6--fastapi.netlify.app

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 51a21a0 at: https://62d3346943a4525bf5973154--fastapi.netlify.app

@JulianMaurin

Copy link
Copy Markdown
Contributor Author

@jburckel

I've made some suggestions to the text. I hope it was the right method 😅 and that it will be useful.

Yes was, thanks 🙏

There is still missing space after colon ponctuation, like for example line 36 to 42. But I think I've already made too much suggestions.

93475d2

Validating there are no more missing withspaces using the following expressions:

  • before colon: [^( |https|text/-align)]:
  • after colon: :[^( |\/\/|15px|app|8)]

I would also be favorable to put a space after the three dots as in the expression '... de' (line 383). But I wasn't sure at 100%...

51a21a0

According to LeConjugeur you are right.

Validating using the following expressions:

  • additional withspaces before ellipsis: \.\.\.
  • missing withspaces after ellipsis: \.\.\.[^( |\])]

I would like to contribute from time to time. Let me know what the best method to help when reviewing the translation.

Reviewing PRs is great! You can also take a look at the documentation and at #1972 to add you own translations :)

@JulianMaurin JulianMaurin force-pushed the feat/translation-fr-index branch from 51a21a0 to 1696767 Compare July 16, 2022 22:20
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 1696767 at: https://62d33a4104222759faaa8464--fastapi.netlify.app

@tiangolo

Copy link
Copy Markdown
Member

It seems this was translated at some point in another PR. So I'll close this one, but thanks for the effort! ☕

@tiangolo tiangolo closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review lang-all Translations lang-fr French translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants