🌐 Add Japanese translation for Advanced - Path Operation Advanced Configuration#2124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2124 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 243 243
Lines 7419 7419
=========================================
Hits 7419 7419 Continue to review full report at Codecov.
|
ae494ca to
c6ecd33
Compare
c6ecd33 to
69a62ab
Compare
|
📝 Docs preview for commit 69a62ab at: https://5f7832c683304ee2b4f88cd7--fastapi.netlify.app |
tokusumi
left a comment
There was a problem hiding this comment.
thank you for great work. I commented some feedback.
Co-authored-by: T. Tokusumi <[email protected]>
|
@tokusumi Thank you for your nice suggestions ! I've fix everything, so please check again. |
|
📝 Docs preview for commit 3f5463a at: https://5f79845cc2c10c910d740a16--fastapi.netlify.app |
|
I resolved all conflicts (All were mkdocs nav order) |
|
📝 Docs preview for commit e381456 at: https://5f8bf9e12ff9408589abed7c--fastapi.netlify.app |
tokusumi
left a comment
There was a problem hiding this comment.
sorry for late response.
great work!
|
@tiangolo, This PR is Japanese tlanslation. could you add some labels? |
delhi09
left a comment
There was a problem hiding this comment.
It looks mostly good.
I pointed out some details.
| !!! warning "注意" | ||
| あなたがOpenAPIの「エキスパート」でなければ、これは必要ないかもしれません。 | ||
|
|
||
| *path operation* で `operationId` パラメータを利用することで、OpenAPIの `operationId` を設定できます。 |
There was a problem hiding this comment.
First "operationId" should be "operation_id" because its's Python's arg name.
|
|
||
| *path operation* で `operationId` パラメータを利用することで、OpenAPIの `operationId` を設定できます。 | ||
|
|
||
| 各オペレーションで一意にする必要があります。 |
There was a problem hiding this comment.
In my opinion, Its' a little better to add "operationIdは" before "各オペレーションで" because I feel the subject of the sentence is a little difficult to understand.
|
@delhi09 Thank you for your nice suggestions ! I've fix everything, so please check again. |
|
📝 Docs preview for commit 3066853 at: https://5ff7c1601449a800901f78cd--fastapi.netlify.app |
|
Great! Thanks @Attsun1031 ! 🙇 🚀 |
This PR translates the advanced/path-operation-advanced-configuration.md to Japanese.
Please review advanced/path-operation-advanced-configuration.md and ja/mkdocs.yml.