Thanks to visit codestin.com
Credit goes to github.com

Skip to content

📝 Fix renamed parameter content_type typo#2135

Merged
tiangolo merged 2 commits into
fastapi:masterfrom
TeoZosa:fix-renamed-parameter-content_type-typo
Nov 5, 2020
Merged

📝 Fix renamed parameter content_type typo#2135
tiangolo merged 2 commits into
fastapi:masterfrom
TeoZosa:fix-renamed-parameter-content_type-typo

Conversation

@TeoZosa

@TeoZosa TeoZosa commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The content_type parameter was renamed to response_class in release 0.19.0

Tangential question to maintainers:

This is the 3rd documentation-related PR I've opened this week. They all fall into different categories, but all have fairly small changes.

  • Is this disruptive?
  • Would it be better to condense any near-future PRs into a single "documentation" PR?

Thanks in advance!

@codecov

codecov Bot commented Oct 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77ea63...1d9f1ad. Read the comment docs.

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 1d9f1ad at: https://5f7b7021d6d83e2d86a400a7--fastapi.netlify.app

@tiangolo tiangolo changed the title Fix renamed parameter content_type typo 📝 Fix renamed parameter content_type typo Nov 5, 2020
@tiangolo tiangolo merged commit 730ded2 into fastapi:master Nov 5, 2020
@tiangolo

tiangolo commented Nov 5, 2020

Copy link
Copy Markdown
Member

Awesome! Thank you @TeoZosa ! 🔍 ☕

About the question, it's perfect like this, in different PRs. That way if for example, I didn't want to accept one of them but I wanted the other 3, I could just merge the other 3.

But if it was all in a single PR, I wouldn't be able to merge all the things from the other 3, waiting for changes to that little thing I didn't want.

Thanks for your contribution! 🍰 🎉

@TeoZosa

TeoZosa commented Nov 6, 2020

Copy link
Copy Markdown
Contributor Author

Awesome! Thank you @TeoZosa ! 🔍 ☕

About the question, it's perfect like this, in different PRs. That way if for example, I didn't want to accept one of them but I wanted the other 3, I could just merge the other 3.

But if it was all in a single PR, I wouldn't be able to merge all the things from the other 3, waiting for changes to that little thing I didn't want.

Thanks for your contribution! 🍰 🎉

Perfect! Thanks for the feedback!

@TeoZosa TeoZosa deleted the fix-renamed-parameter-content_type-typo branch November 6, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants