Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for Tutorial - Testing#2259

Merged
tiangolo merged 5 commits into
fastapi:masterfrom
tokusumi:translation/add-ja-tutorial-testing
Feb 7, 2021
Merged

🌐 Add Japanese translation for Tutorial - Testing#2259
tiangolo merged 5 commits into
fastapi:masterfrom
tokusumi:translation/add-ja-tutorial-testing

Conversation

@tokusumi

@tokusumi tokusumi commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

This PR translates tutorial/testing.md in Japanese.

@tokusumi tokusumi mentioned this pull request Oct 28, 2020
Closed
@codecov

codecov Bot commented Oct 28, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2259 (8336fa6) into master (17781e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2259   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88fb2e...8336fa6. Read the comment docs.

@github-actions

github-actions Bot commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit fab4df7 at: https://5f99769450c750b68b9ce278--fastapi.netlify.app

komtaki
komtaki reviewed Nov 3, 2020
View reviewed changes

@komtaki komtaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. 👍

I suggested one minor change.

Comment thread docs/ja/docs/tutorial/testing.md Outdated
@tokusumi

tokusumi commented Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

Thank you for your review!

@github-actions

github-actions Bot commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 6af5432 at: https://5fa0c762a2b1c44c38431da5--fastapi.netlify.app

komtaki
komtaki approved these changes Nov 3, 2020
View reviewed changes

@komtaki komtaki left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

sh0nk
sh0nk reviewed Jan 11, 2021
View reviewed changes

@sh0nk sh0nk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single typo. The others look good!

Comment thread docs/ja/docs/tutorial/testing.md Outdated
@github-actions

github-actions Bot commented Jan 11, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 6c11914 at: https://5ffcd77a49593800ddf21b8d--fastapi.netlify.app

@tokusumi

tokusumi commented Jan 11, 2021

Copy link
Copy Markdown
Contributor Author

Thank you @sh0nk for your review!
I applied your suggestion. Please check it again.

sh0nk
sh0nk approved these changes Jan 12, 2021
View reviewed changes

@sh0nk sh0nk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tiangolo

tiangolo commented Feb 7, 2021

Copy link
Copy Markdown
Member

Awesome @tokusumi ! 👏 👏 🚀

And thanks a lot @sh0nk and @komtaki as always for the reviews. 🙇 ☕

@github-actions

github-actions Bot commented Feb 7, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 8336fa6 at: https://60202373095b3221539e3697--fastapi.netlify.app

@tiangolo tiangolo merged commit cd8b90a into fastapi:master Feb 7, 2021
@tokusumi tokusumi deleted the translation/add-ja-tutorial-testing branch May 5, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sh0nk sh0nk sh0nk approved these changes

@komtaki komtaki komtaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 hacktoberfest-accepted lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tokusumi @tiangolo @sh0nk @komtaki