Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for docs/ja/docs/deployment/https.md#2311

Closed
tokusumi wants to merge 7 commits into
fastapi:masterfrom
tokusumi:translation/add-ja-deployment-https
Closed

🌐 Add Japanese translation for docs/ja/docs/deployment/https.md#2311
tokusumi wants to merge 7 commits into
fastapi:masterfrom
tokusumi:translation/add-ja-deployment-https

Conversation

@tokusumi

@tokusumi tokusumi commented Nov 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR translates deployment/https.md in Japanese.

To all reviewers. This section is only separated from #1948 (with few changes), but please review it.

@codecov

codecov Bot commented Nov 6, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (345a8a0) 100.00%.

❗ Current head 345a8a0 differs from pull request most recent head 846636f. Consider uploading reports for the commit 846636f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #2311    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13672   -297     
==========================================
- Hits         13969     13672   -297

see 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit a6c8e8e at: https://5fa53127715c7fe8b1545967--fastapi.netlify.app

@tokusumi tokusumi mentioned this pull request Nov 6, 2020
Closed
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Nov 7, 2020
sh0nk
sh0nk reviewed Jan 15, 2021
View reviewed changes

@sh0nk sh0nk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks!

Comment thread docs/ja/docs/deployment/https.md Outdated
Comment thread docs/ja/docs/deployment/https.md Outdated
Comment thread docs/ja/docs/deployment/https.md Outdated
Comment thread docs/ja/docs/deployment/https.md Outdated
@github-actions

github-actions Bot commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 0feef34 at: https://6001bd04f0a0cb4b0ac76aec--fastapi.netlify.app

@github-actions

github-actions Bot commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 2c72d04 at: https://6001bfad75dde528881052da--fastapi.netlify.app

@tokusumi

tokusumi commented Jan 15, 2021

Copy link
Copy Markdown
Contributor Author

Thank you @sh0nk !
I accepted your suggestions. And fixed some weird translation.
could you check it again?

sh0nk
sh0nk approved these changes Jan 15, 2021
View reviewed changes

@sh0nk sh0nk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! 👍

@github-actions

github-actions Bot commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 345a8a0 at: https://62b5af0913f0ea005610c966--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Japanese translation for Deployment - HTTPS 🌐 Add Japanese translation for docs/ja/docs/deployment/https.md Jun 26, 2023
@tiangolo

tiangolo commented Jun 26, 2023

Copy link
Copy Markdown
Member

📝 Docs preview for commit 846636f at: https://649a13ba443f2f103c861546--fastapi.netlify.app

@tiangolo

tiangolo commented Jan 15, 2024

Copy link
Copy Markdown
Member

It seems this was handled in #10298, so I'm gonna close this one. Thank you! ☕

@tiangolo tiangolo closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sh0nk sh0nk sh0nk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tokusumi @tiangolo @sh0nk