Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for Deployment - Docker#2312

Merged
tiangolo merged 4 commits into
fastapi:masterfrom
tokusumi:translation/add-ja-deployment-docker
Feb 7, 2021
Merged

🌐 Add Japanese translation for Deployment - Docker#2312
tiangolo merged 4 commits into
fastapi:masterfrom
tokusumi:translation/add-ja-deployment-docker

Conversation

@tokusumi

@tokusumi tokusumi commented Nov 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR translates deployment/docker.md in Japanese.

To all reviewers. This section is only separated from #1948 (with few changes), but please review it.

@codecov

codecov Bot commented Nov 6, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2312 (1e93bde) into master (f031973) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb40e27...1e93bde. Read the comment docs.

@github-actions

github-actions Bot commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 7ac04c7 at: https://5fa5337031aca1f4432e396a--fastapi.netlify.app

@tokusumi tokusumi mentioned this pull request Nov 6, 2020
Closed
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Nov 7, 2020
komtaki
komtaki reviewed Nov 8, 2020
View reviewed changes

@komtaki komtaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your nice work.

I commented one suggestion.

Comment thread docs/ja/docs/deployment/docker.md Outdated
@tokusumi

tokusumi commented Nov 8, 2020

Copy link
Copy Markdown
Contributor Author

Thank you for your review!

@github-actions

github-actions Bot commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 9a0e15a at: https://5fa7a72d8d2a1aebd5180f4a--fastapi.netlify.app

komtaki
komtaki approved these changes Nov 8, 2020
View reviewed changes

@komtaki komtaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you : )

sh0nk
sh0nk reviewed Jan 11, 2021
View reviewed changes

@sh0nk sh0nk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time review on PRs. If I don't follow any convention etc., please kindly forget about the comments!

Comment thread docs/ja/docs/deployment/docker.md Outdated
Comment thread docs/ja/docs/deployment/docker.md Outdated
Comment thread docs/ja/docs/deployment/docker.md Outdated
Comment thread docs/ja/docs/deployment/docker.md Outdated
Comment thread docs/ja/docs/deployment/docker.md Outdated
Comment thread docs/ja/docs/deployment/docker.md Outdated
Comment thread docs/ja/docs/deployment/docker.md Outdated
Comment thread docs/ja/docs/deployment/docker.md Outdated
Comment thread docs/ja/docs/deployment/docker.md Outdated
@github-actions

github-actions Bot commented Jan 11, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 1e93bde at: https://5ffccaf90221081658744aa5--fastapi.netlify.app

@tokusumi

tokusumi commented Jan 11, 2021

Copy link
Copy Markdown
Contributor Author

Thank you for your first review! @sh0nk
I applied your suggestions. Please check it again.

sh0nk
sh0nk approved these changes Jan 12, 2021
View reviewed changes

@sh0nk sh0nk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM 👍

@tiangolo

tiangolo commented Feb 7, 2021

Copy link
Copy Markdown
Member

Awesome @tokusumi ! 🚀 🍰

And thanks for the reviews @sh0nk and @komtaki ! 🙇 🍰 ☕

@tiangolo tiangolo merged commit 08cbc6c into fastapi:master Feb 7, 2021
@tokusumi tokusumi deleted the translation/add-ja-deployment-docker branch May 5, 2021 08:10
@tamtam-fitness tamtam-fitness mentioned this pull request Aug 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sh0nk sh0nk sh0nk approved these changes

@komtaki komtaki komtaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tokusumi @tiangolo @sh0nk @komtaki