Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 Ensure that HTTPDigest only raises an exception when auto_error is True #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiangolo merged 5 commits into from
Feb 27, 2025
Merged

🐛 Ensure that HTTPDigest only raises an exception when auto_error is True #2939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77b610e
Digest should raise exception if auto_error is True
arthurio Mar 12, 2021
0e6ef5e
Update tests
arthurio Sep 13, 2023
5369e22
Remove uneeded else statements.
arthurio Jan 8, 2022
576a4f8
revert to original style using an else statement for the fall-back
svlandeg Feb 26, 2025
94983f4
Merge branch 'master' into digest-except
svlandeg Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions fastapi/security/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,11 @@ async def __call__(
else:
return None
if scheme.lower() != "digest":
raise HTTPException(
status_code=HTTP_403_FORBIDDEN,
detail="Invalid authentication credentials",
)
if self.auto_error:
raise HTTPException(
status_code=HTTP_403_FORBIDDEN,
detail="Invalid authentication credentials",
)
else:
Comment thread
svlandeg marked this conversation as resolved.
return None
return HTTPAuthorizationCredentials(scheme=scheme, credentials=credentials)
4 changes: 2 additions & 2 deletions tests/test_security_http_digest_optional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ def test_security_http_digest_incorrect_scheme_credentials():
response = client.get(
"/users/me", headers={"Authorization": "Other invalidauthorization"}
)
assert response.status_code == 403, response.text
Comment thread
svlandeg marked this conversation as resolved.
assert response.json() == {"detail": "Invalid authentication credentials"}
assert response.status_code == 200, response.text
assert response.json() == {"msg": "Create an account first"}


def test_openapi_schema():
Expand Down