♻ Refactor dict value extraction to minimize key lookups fastapi/utils.py#3139
Merged
tiangolo merged 2 commits intoMay 12, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 531 531
Lines 13629 13629
=========================================
Hits 13629 13629
Continue to review full report at Codecov.
|
Contributor
|
📝 Docs preview for commit 32df705 at: https://608d277e521eb71b0f16ecd0--fastapi.netlify.app |
ycd
approved these changes
May 3, 2021
fastapi/utils.py
Member
|
Nice, thank you! 😎🚀 |
JeanArhancet
pushed a commit
to JeanArhancet/fastapi
that referenced
this pull request
Aug 20, 2022
…ls.py` (fastapi#3139) Co-authored-by: Sebastián Ramírez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 3 extra key/value lookups for update_dict, it can be eliminated by unpacking value in for loop directly.