Conversation
- Complemented a few uncomfortable translations. - Changed the tones of some sentences to suit the standard translation guide.
hard-coders
approved these changes
May 2, 2021
hard-coders
left a comment
Contributor
There was a problem hiding this comment.
I didn't realize it at all, even though I wrote a #2017.
Thanks a lot!
hard-coders
approved these changes
May 3, 2021
Member
|
Awesome, thank you @SueNaEunYang! 🤓 🔍 As @hard-coders already approved it and he's leading the Korean translations, I'll merge it right away, without waiting for more approvals. 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #3159 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 243 243
Lines 7419 7419
=========================================
Hits 7419 7419 Continue to review full report at Codecov.
|
Contributor
|
📝 Docs preview for commit e78d8a6 at: https://60910a2c702c4b00800f0963--fastapi.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thank you all for your efforts.
While reading your translations, I found tiny things that I would recommend to change.
Please see if you like those changes, and feel free to tell me if not :)
This PR complements
docs/ko/docs/index.md(Korean translation of index.md)related : #2017