📝 Update docs for handling HTTP Basic Auth with secrets.compare_digest() to account for non-ASCII characters#3536
Merged
Conversation
secrets.compare_digest() to account for non-ASCII characters
Codecov Report
@@ Coverage Diff @@
## master #3536 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 533 533
Lines 13755 13755
=========================================
Hits 13755 13755 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Thank you @lewoudar! 🤓 I updated the example and docs a bit to make it more explicit. I used UTF-8 instead of IDNA, as this is not related to domains. I reverted the change in the docstring to put it in a different PR as that is a different thing. Also because only removing that line also left the example code broken. But let's fix that in another PR later. Thanks for your contribution! 🍰 |
Contributor
Author
|
@tiangolo perfect! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated by @tiangolo:
📝 Update docs for handling HTTP Basic Auth with
secrets.compare_digest()to account for non-ASCII characters.