Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add German translation for docs/features.md#3699

Merged
tiangolo merged 5 commits into
fastapi:masterfrom
mawassk:german-translation-features
Sep 13, 2021
Merged

🌐 Add German translation for docs/features.md#3699
tiangolo merged 5 commits into
fastapi:masterfrom
mawassk:german-translation-features

Conversation

@mawassk

@mawassk mawassk commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@tiangolo

tiangolo commented Aug 18, 2021

Copy link
Copy Markdown
Member

Awesome! Thanks for your contribution. 🚀

These translations depend mainly on having more people that speak the language review them, once I have two reviews approving a translation PR I can merge it.

I just created a new issue to track these translations, you can comment there and subscribe, and probably also check if there are other PRs by others you could review. 🤓

#3716

@tiangolo tiangolo added awaiting-review lang-all Translations lang-de German translations labels Aug 18, 2021
@github-actions github-actions Bot mentioned this pull request Aug 18, 2021
Closed
@codecov

codecov Bot commented Aug 18, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3699 (43d1938) into master (25a4828) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3699   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       410    +1     
  Lines        10244     10281   +37     
=========================================
+ Hits         10244     10281   +37
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
tests/test_read_with_orm_mode.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a4828...43d1938. Read the comment docs.

@github-actions

github-actions Bot commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 9f3fe85 at: https://611d0fc9b5ffd20e08ee084d--fastapi.netlify.app

d-e-h-i-o
d-e-h-i-o approved these changes Aug 20, 2021
View reviewed changes

@d-e-h-i-o d-e-h-i-o left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found this one issue. Otherwise looks great!

Comment thread docs/de/docs/features.md Outdated
rogerbrinkmann
rogerbrinkmann suggested changes Aug 28, 2021
View reviewed changes
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
Comment thread docs/de/docs/features.md Outdated
@mawassk

mawassk commented Aug 29, 2021

Copy link
Copy Markdown
Contributor Author

Thank you for your feedback @rogerbrinkmann! I updated my PR 🚀

@tiangolo

tiangolo commented Sep 13, 2021

Copy link
Copy Markdown
Member

Awesome, thank you @mawassk! 🍰 ☕

And thanks for the reviews @rogerbrinkmann and @d-e-h-i-o! 👏

@github-actions

github-actions Bot commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 43d1938 at: https://613f825dbe6ef90d00736a91--fastapi.netlify.app

@tiangolo tiangolo merged commit 3a786a7 into fastapi:master Sep 13, 2021
@mawassk mawassk deleted the german-translation-features branch September 13, 2021 17:35
@kritsada1998mtcn-ctrl kritsada1998mtcn-ctrl mentioned this pull request Nov 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rogerbrinkmann rogerbrinkmann rogerbrinkmann approved these changes

@d-e-h-i-o d-e-h-i-o d-e-h-i-o approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-de German translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mawassk @tiangolo @rogerbrinkmann @d-e-h-i-o