Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Korean translation for docs/tutorial/cors.md#3764

Merged
tiangolo merged 24 commits into
fastapi:masterfrom
NinaHwang:tutorial/cors
Jan 7, 2023
Merged

🌐 Add Korean translation for docs/tutorial/cors.md#3764
tiangolo merged 24 commits into
fastapi:masterfrom
NinaHwang:tutorial/cors

Conversation

@NinaHwang

@NinaHwang NinaHwang commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

This PR translates tutorial/cors.md in Korean.

related: #2017

zhoonit
zhoonit reviewed Aug 26, 2021
View reviewed changes
Comment thread docs/ko/docs/tutorial/cors.md Outdated
zhoonit
zhoonit reviewed Aug 26, 2021
View reviewed changes
Comment thread docs/ko/docs/tutorial/cors.md Outdated
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Oct 5, 2021
@github-actions github-actions Bot mentioned this pull request Oct 5, 2021
Closed
@codecov

codecov Bot commented Oct 5, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d2baf2b) compared to base (cf73051).
Patch has no changes to coverable lines.

❗ Current head d2baf2b differs from pull request most recent head c57eb55. Consider uploading reports for the commit c57eb55 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #3764     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       409    -131     
  Lines        13969     10264   -3705     
===========================================
- Hits         13969     10264   -3705
Impacted Files Coverage Δ
tests/main.py 100.00% <0.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
tests/test_query.py 100.00% <0.00%> (ø)
fastapi/exceptions.py 100.00% <0.00%> (ø)
fastapi/websockets.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit eb256b7 at: https://615c2b1f0167e3db70394127--fastapi.netlify.app

zhoonit
zhoonit approved these changes Oct 5, 2021
View reviewed changes

@zhoonit zhoonit left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it looks good :)

0417taehyun
0417taehyun reviewed Nov 3, 2021
View reviewed changes

@0417taehyun 0417taehyun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the supplementary explanation by using () and English in it.

Feel free to check my reviews. Big appreciate your works and great honor to check it 🚀

Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
Comment thread docs/ko/docs/tutorial/cors.md Outdated
NinaHwang and others added 16 commits November 5, 2021 09:56
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
3ef08c7 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
808ac6f 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
0890ca2 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
758776c 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
b9779cd 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
3852330 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
751b178 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
4c37a11 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
49ab483 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
d327406 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
181889e 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
1e61488 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
ce27d15 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
5f8292f 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
8ff1d2a 
Co-authored-by: weekwith.me <[email protected]>
@NinaHwang @0417taehyun
Update docs/ko/docs/tutorial/cors.md
14f32fe 
Co-authored-by: weekwith.me <[email protected]>
@github-actions

github-actions Bot commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 14f32fe at: https://618483236a1de84a306a808d--fastapi.netlify.app

@github-actions

github-actions Bot commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 927705a at: https://61b159f15d8217913d5398b1--fastapi.netlify.app

@github-actions

github-actions Bot commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit d2baf2b at: https://61b212d819a88e5519b3a45c--fastapi.netlify.app

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#3764
3ff0b36
0417taehyun
0417taehyun approved these changes Dec 29, 2022
View reviewed changes

@0417taehyun 0417taehyun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions

github-actions Bot commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit c57eb55 at: https://63ad185d6b1d064da6500600--fastapi.netlify.app

@tiangolo

tiangolo commented Jan 7, 2023

Copy link
Copy Markdown
Member

Awesome, thank you @NinaHwang! 🙇

Thanks for the reviews @zhoonit, @0417taehyun ☕ 🍰

@tiangolo tiangolo merged commit 2a3a786 into fastapi:master Jan 7, 2023
JonasKs pushed a commit to JonasKs/fastapi that referenced this pull request Jan 12, 2023
@NinaHwang @0417taehyun
@tiangolo @pre-commit-ci @JonasKs
🌐 Add Korean translation for docs/tutorial/cors.md (fastapi#3764)
c8a7da2 
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: Sebastián Ramírez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
axel584 pushed a commit to axel584/fastapi that referenced this pull request Mar 5, 2023
@NinaHwang @0417taehyun
@tiangolo @pre-commit-ci @axel584
🌐 Add Korean translation for docs/tutorial/cors.md (fastapi#3764)
8fba098 
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: Sebastián Ramírez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mahenzon pushed a commit to mahenzon/fastapi that referenced this pull request Mar 11, 2023
@NinaHwang @0417taehyun
@tiangolo @pre-commit-ci @mahenzon
🌐 Add Korean translation for docs/tutorial/cors.md (fastapi#3764)
11e8c63 
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: Sebastián Ramírez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@zhoonit zhoonit zhoonit approved these changes

@0417taehyun 0417taehyun 0417taehyun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NinaHwang @tiangolo @zhoonit @0417taehyun