Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Azerbaijani language setup#3919

Closed
madatbay wants to merge 1 commit into
fastapi:masterfrom
madatbay:master
Closed

Azerbaijani language setup#3919
madatbay wants to merge 1 commit into
fastapi:masterfrom
madatbay:master

Conversation

@madatbay

Copy link
Copy Markdown
Contributor

Azerbaijani language has been set up

@madatbay

Copy link
Copy Markdown
Contributor Author

Is there any problem with merge?

Comment thread docs/en/mkdocs.yml
permalink: true
- markdown.extensions.codehilite:
guess_lang: false
# Uncomment these 2 lines during development to more easily add highlights

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't removed it on purpose. Just run new-lang az and not played with other lang fixes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add it back, probably a bug that it removes the comment

Comment thread docs/az/docs/index.md
@@ -0,0 +1,467 @@

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a while ago we agreed that initial translation file (index.md) should be a separate pull request to just the setup for the docs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this pull request just contains a new language setup, not index.md translations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just remove the index.md all together?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean there is no need for the untranslated version of index.md too? Okay I will remove it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@madatbay

Copy link
Copy Markdown
Contributor Author

PR moved to #3941

@madatbay madatbay closed this Sep 24, 2021
@tiangolo tiangolo changed the title [lang-az] Azerbaijani language setup Azerbaijani language setup Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants