Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added flags to coverage upload depending if it is a PR or a push and …#3982

Closed
ghandic wants to merge 2 commits into
fastapi:masterfrom
ghandic:fix/cov-test-badge
Closed

Added flags to coverage upload depending if it is a PR or a push and …#3982
ghandic wants to merge 2 commits into
fastapi:masterfrom
ghandic:fix/cov-test-badge

Conversation

@ghandic

@ghandic ghandic commented Oct 3, 2021

Copy link
Copy Markdown
Contributor

…updated badge icon to point only to master flag

@codecov

codecov Bot commented Oct 3, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3982 (9695df2) into master (284eb66) will increase coverage by 5.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #3982      +/-   ##
===========================================
+ Coverage   94.36%   100.00%   +5.63%     
===========================================
  Files         478       410      -68     
  Lines       12324     10281    -2043     
===========================================
- Hits        11629     10281    -1348     
+ Misses        695         0     -695     
Flag Coverage Δ
pr 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fastapi/utils.py 100.00% <0.00%> (ø)
..._tutorial/test_sql_databases/test_sql_databases.py 100.00% <0.00%> (ø)
...orial/test_sql_databases/test_testing_databases.py 100.00% <0.00%> (ø)
...rial/test_response_model/test_tutorial004_py310.py
...utorial/test_extra_models/test_tutorial004_py39.py
docs_src/security/tutorial005_py39.py
docs_src/sql_databases/sql_app_py310/alt_main.py
.../test_sql_databases/test_testing_databases_py39.py
docs_src/sql_databases/sql_app_py39/main.py
docs_src/sql_databases/sql_app_py310/database.py
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284eb66...9695df2. Read the comment docs.

@github-actions

github-actions Bot commented Oct 3, 2021

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 9695df2 at: https://615a36184dde926297f018bc--fastapi.netlify.app

@tiangolo

Copy link
Copy Markdown
Member

Thanks for your interest @ghandic! I was checking that there's no need to use flags, it's possible to use the same current badges pointing to master.

But still, it seems that leaving them as they are they already point to master. I just created a broken PR here: #4887 removing lots of tests, that would reduce the coverage. But the badges still seem to show 100%, so it seems that by default they show the percentage of master.

Given that, I'll close this PR now, but thanks for the effort!

@tiangolo tiangolo closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants