📝 Update docs/tutorial/dependencies/classes-as-dependencies: Add type of query parameters in a description of Classes as dependencies#4015
Merged
Conversation
ArcLightSlavik
approved these changes
Oct 8, 2021
TestRights
reviewed
Oct 17, 2021
| @@ -91,9 +91,9 @@ Those parameters are what **FastAPI** will use to "solve" the dependency. | |||
|
|
|||
TestRights
approved these changes
Oct 17, 2021
Member
|
Yep, makes sense. Thanks @0417taehyun! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #4015 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 409 409
Lines 10264 10264
=========================================
Hits 10264 10264 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description of
common_parametersof parameters inDependecies - First stepshas types like "An optional query parameterqthat is astr."I think it is better to add type in a description of Class as dependencies in
Classes as Dependenciestoo, like "An optionalqquery parameter that isstr".