Codestin Search App

sUeharaE4 · 2021-11-23T12:55:10Z

Relates to #1572

This PR translates advanced/nosql-databases.md.

I left "databases" in the page title as it is because there is no word for the plural of database in Japanese.
This is my first pull request, so I apologize if there are any problems. I would appreciate it if you could check it.

github-actions · 2021-12-08T15:12:37Z

📝 Docs preview for commit 96bd631 at: https://61b0caec4bb4cd2a61ab32e4--fastapi.netlify.app

codecov · 2021-12-08T15:14:09Z

Codecov Report

Merging #4205 (0b29c08) into master (1876ebc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #4205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13672     13672           
=========================================
  Hits         13672     13672

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1876ebc...0b29c08. Read the comment docs.

dimaqq

I'm not a native speaker, but this seems solid!

wakabame

Excellent work!!

dimaqq · 2022-06-16T04:52:50Z

@tiangolo this should be ready, let's merge!

tokusumi

Thank you for great work!!!
I'd like to suggests the followings, although already you've gotten enough approve.

tokusumi · 2022-06-16T12:30:46Z

@@ -0,0 +1,155 @@
+# NoSQL (分散 / ビッグデータ) Databases
+
+**FastAPI** はあらゆる <abbr title="分散データベース (Big Data), や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。


Suggested change

**FastAPI** はあらゆる <abbr title="分散データベース (Big Data), や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。

**FastAPI** はあらゆる <abbr title="分散データベース (Big Data)や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。

we could omit "," or put it after "や"

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL3

tokusumi · 2022-06-16T12:42:19Z

+
+この関数では:
+
+* **Couchbase** クラスタ(1台の場合もあるでしょう)に接続し


Here too rough writing are used than other sections. I suggest to delete some "し" and "して" at all lines.

Thank you to suggests. I applied arround here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL48

tokusumi · 2022-06-16T12:46:14Z

+
+## Pydantic モデルの作成
+
+**Couchbase**のdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルにすることが出来ます。


Suggested change

**Couchbase**のdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルにすることが出来ます。

**Couchbase**のdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルに出来ます。

Suggesting shorten expression at the end of a sentence.

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL63

tokusumi · 2022-06-16T12:58:41Z

+{!../../../docs_src/nosql_databases/tutorial001.py!}
+```
+
+このモデルは*path operation*で利用できる関数で使用するので`hashed_password`はモデルに含めません。


Suggested change

このモデルは*path operation*で利用できる関数で使用するので`hashed_password`はモデルに含めません。

このモデルは*path operation*に使用するので、`hashed_password`は含めません。

This is difficult to translate. Here, path operation (function) refer to read_user function.

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL73

tokusumi · 2022-06-16T13:02:34Z

+{!../../../docs_src/nosql_databases/tutorial001.py!}
+```
+
+!!! note


Suggested change

!!! note

!!! note "備考"

Unified at translation tracking issue

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL87

tokusumi · 2022-06-16T13:06:04Z

+
+それでは次の関数を作成しましょう:
+
+* username を取得して


Same as above suggestion. Deleting "して" or Replacing with "する" are better.

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL96

tokusumi · 2022-06-16T13:09:09Z

+{!../../../docs_src/nosql_databases/tutorial001.py!}
+```
+
+### f-strings


Suggested change

### f-strings

### f-strings

Maybe newline needs after heading.

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL96

tokusumi · 2022-06-16T13:15:57Z

+
+## "document type" として利用する定数の定義 
+
+documentで利用する固定のフィールド`type`を用意しておきます。


Suggested change

documentで利用する固定のフィールド`type`を用意しておきます。

documentで利用する固定の`type`フィールドを用意しておきます。

More easier to read?

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL28

tokusumi · 2022-06-16T13:34:51Z

+* **ArangoDB**
+* **ElasticSearch** など。
+
+!!! 豆知識


Suggested change

!!! 豆知識

!!! tip "豆知識"

I'm not sure but maybe this is (or was) right syntax.

Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL15

github-actions · 2022-06-18T07:37:24Z

📝 Docs preview for commit 99a1523 at: https://62ad80850151d34b7adb7eb3--fastapi.netlify.app

Co-authored-by: tokusumi <[email protected]>

github-actions · 2022-06-18T13:49:43Z

📝 Docs preview for commit 0b29c08 at: https://62add7c6b9dd507f67334965--fastapi.netlify.app

tokusumi

LGTM

tiangolo · 2022-08-18T15:54:01Z

Thanks for the contribution @sUeharaE4! 🍰

And thank you for the reviews @dimaqq, @wakabame, and @tokusumi! ☕

….md` (fastapi#4205) Co-authored-by: tokusumi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

sUeharaE4 added 2 commits November 23, 2021 21:34

Add Japanese translation for - docs/ja/docs/advanced/nosql-databases.md

f5f4272

Update: remove redundant expressions

96bd631

tiangolo changed the title ~~Add Japanese translation for Advanced - NoSQL Databases~~ 🌐 Add Japanese translation for docs/ja/docs/advanced/nosql-databases.md Dec 8, 2021

tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Dec 8, 2021

github-actions Bot mentioned this pull request Dec 8, 2021

Japanese Translation #1572

Closed

dimaqq approved these changes Jan 8, 2022

View reviewed changes

wakabame approved these changes Jun 16, 2022

View reviewed changes

github-actions Bot added approved-2 and removed awaiting-review labels Jun 16, 2022

tokusumi suggested changes Jun 16, 2022

View reviewed changes

tokusumi reviewed Jun 16, 2022

View reviewed changes

sUeharaE4 and others added 3 commits June 18, 2022 16:24

Update: Apply suggestions from review

6866770

Merge branch 'master' into add-ja-translate-advanced-nosqldatabases

2cbea51

🎨 [pre-commit.ci] Auto format from pre-commit.com hooks

99a1523

tokusumi suggested changes Jun 18, 2022

View reviewed changes

Comment thread docs/ja/docs/advanced/nosql-databases.md Outdated

Update: Apply suggestions from review

0b29c08

Co-authored-by: tokusumi <[email protected]>

tokusumi approved these changes Jun 19, 2022

View reviewed changes

tiangolo merged commit e23fa40 into fastapi:master Aug 18, 2022

		@@ -0,0 +1,155 @@
		# NoSQL (分散 / ビッグデータ) Databases

		FastAPI はあらゆる <abbr title="分散データベース (Big Data), や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。


		この関数では:

		* Couchbase クラスタ(1台の場合もあるでしょう)に接続し


		## Pydantic モデルの作成

		Couchbaseのdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルにすることが出来ます。

	このモデルはpath operationで利用できる関数で使用するので`hashed_password`はモデルに含めません。
	このモデルはpath operationに使用するので、`hashed_password`は含めません。


		それでは次の関数を作成しましょう:

		* username を取得して


		## "document type" として利用する定数の定義

		documentで利用する固定のフィールド`type`を用意しておきます。

	documentで利用する固定のフィールド`type`を用意しておきます。
	documentで利用する固定の`type`フィールドを用意しておきます。

Uh oh!

Conversation

sUeharaE4 commented Nov 23, 2021

Uh oh!

github-actions Bot commented Dec 8, 2021

Uh oh!

codecov Bot commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dimaqq left a comment

Choose a reason for hiding this comment

Uh oh!

wakabame left a comment

Choose a reason for hiding this comment

Uh oh!

dimaqq commented Jun 16, 2022

Uh oh!

tokusumi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tokusumi Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sUeharaE4 Jun 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 18, 2022

Uh oh!

Uh oh!

github-actions Bot commented Jun 18, 2022

Uh oh!

tokusumi left a comment

Choose a reason for hiding this comment

Uh oh!

tiangolo commented Aug 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

codecov Bot commented Dec 8, 2021 •

edited

Loading

tokusumi Jun 16, 2022 •

edited

Loading

sUeharaE4 Jun 18, 2022 •

edited

Loading