Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Fix code examples in Japanese translation for docs/ja/docs/tutorial/testing.md#4623

Merged
tiangolo merged 2 commits into
fastapi:masterfrom
hirotoKirimaru:patch-1
May 11, 2022
Merged

🌐 Fix code examples in Japanese translation for docs/ja/docs/tutorial/testing.md#4623
tiangolo merged 2 commits into
fastapi:masterfrom
hirotoKirimaru:patch-1

Conversation

@hirotoKirimaru

Copy link
Copy Markdown
Contributor

Some codes cannot be copied and pasted.
and then, I copied the codes from the English turorial pages;

target pages

https://fastapi.tiangolo.com/ja/tutorial/testing/

copied from pages

Before View

image

After View

image

@wakabame wakabame left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiangolo tiangolo changed the title 🌐 Fix Code lines for Japanese translation for docs/docs/tutorial/testing.md 🌐 Fix Code lines for Japanese translation for docs/ja/docs/tutorial/testing.md May 11, 2022
@codecov

codecov Bot commented May 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4623 (9a9af55) into master (643291b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #4623   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13629     13629           
=========================================
  Hits         13629     13629           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643291b...9a9af55. Read the comment docs.

@tiangolo tiangolo changed the title 🌐 Fix Code lines for Japanese translation for docs/ja/docs/tutorial/testing.md 🌐 Fix code examples in Japanese translation for docs/ja/docs/tutorial/testing.md May 11, 2022
@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations labels May 11, 2022
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 9a9af55 at: https://627bf48882fd1b0b03a2deeb--fastapi.netlify.app

@tiangolo

Copy link
Copy Markdown
Member

Awesome, thank you @hirotoKirimaru! 🍪

And thanks for the review @wakabame 🙇

@tiangolo tiangolo merged commit a38b0a7 into fastapi:master May 11, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang-all Translations lang-ja Japanese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants