Thanks to visit codestin.com
Credit goes to github.com

Skip to content

⬆️ Bump Uvicorn max range to 0.17.x#4680

Closed
pedropozzobon wants to merge 1 commit into
fastapi:masterfrom
pedropozzobon:master
Closed

⬆️ Bump Uvicorn max range to 0.17.x#4680
pedropozzobon wants to merge 1 commit into
fastapi:masterfrom
pedropozzobon:master

Conversation

@pedropozzobon

Copy link
Copy Markdown

I believe this is important to be done due to:

Kludex/uvicorn#1400
MagicStack/httptools#76

@dynalz

dynalz commented Mar 13, 2022

Copy link
Copy Markdown

New versions of Uvicorn are not compatible with FastAPI, doing a few tests websockets stop working all together.

@pedropozzobon

Copy link
Copy Markdown
Author

@dynalz Can you give more info on this? I've just run the three examples in https://fastapi.tiangolo.com/advanced/websockets/, using the following environment and they seem to be working:

env-example

@Kludex

Kludex commented Mar 19, 2022

Copy link
Copy Markdown
Member

New versions of Uvicorn are not compatible with FastAPI, doing a few tests websockets stop working all together.

An issue on uvicorn on how to reproduce it is appreciated...

@levrik

levrik commented Mar 30, 2022

Copy link
Copy Markdown

@dynalz We're using FastAPI with manually installed Uvicorn, so aren't affected by the limitations of the all extra here. We are running Uvicorn 0.17.x for some time in production now. No issues so far.

@odiseo0

odiseo0 commented Apr 4, 2022

Copy link
Copy Markdown

Same here, installed Uvicorn (standard) separately from FastAPI and it's doing fine, currently in 0.17.6

@tiangolo

Copy link
Copy Markdown
Member

Thanks @pedropozzobon! And thanks for the conversation everyone.

This was included as part of #4803, and it will be available in FastAPI 0.75.2 in a couple of hours, so I'll close this one now.

But thanks for the effort @pedropozzobon! 🍰

@tiangolo tiangolo closed this Apr 17, 2022
pattersam pushed a commit to pattersam/ytta-app that referenced this pull request Sep 9, 2023
this is required for it to stay working with the AWS ELB

Kludex/uvicorn#1199
Kludex/uvicorn#1332

but we're still waiting for `fastapi[all]` to use the newer uvicorn: fastapi/fastapi#4680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants