Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for docs/ja/docs/advanced/websockets.md#4983

Merged
tiangolo merged 5 commits into
fastapi:masterfrom
xryuseix:add-ja-translate-advanced-websockets
Nov 13, 2022
Merged

🌐 Add Japanese translation for docs/ja/docs/advanced/websockets.md#4983
tiangolo merged 5 commits into
fastapi:masterfrom
xryuseix:add-ja-translate-advanced-websockets

Conversation

@xryuseix

@xryuseix xryuseix commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

Relates to #1572

This PR translates advanced/websockets.md.

I am Japanese and I like this repository so I translated it.
This is my first pull request for fastapi, so I apologize if there are any problems. I would appreciate it if you could check it.

@codecov

codecov Bot commented Jun 3, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ee4e6a1) compared to base (cf73051).
Patch has no changes to coverable lines.

❗ Current head ee4e6a1 differs from pull request most recent head 2ace4d0. Consider uploading reports for the commit 2ace4d0 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #4983    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13672   -297     
==========================================
- Hits         13969     13672   -297
Impacted Files Coverage Δ
tests/main.py 100.00% <0.00%> (ø)
tests/utils.py 100.00% <0.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
tests/test_query.py 100.00% <0.00%> (ø)
fastapi/websockets.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/docs.py 100.00% <0.00%> (ø)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 31ea851 at: https://629a33ffacfdc31daf3b4e19--fastapi.netlify.app

tokusumi
tokusumi suggested changes Jun 16, 2022
View reviewed changes

@tokusumi tokusumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate for your contribution!!!

Comment thread docs/ja/docs/advanced/websockets.md Outdated
Comment thread docs/ja/docs/advanced/websockets.md Outdated
@github-actions

github-actions Bot commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit a88f26b at: https://62aba7cf9c45893f00620a58--fastapi.netlify.app

@github-actions

github-actions Bot commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit ee4e6a1 at: https://62aba909520be73ebdb408ef--fastapi.netlify.app

tokusumi
tokusumi approved these changes Jun 17, 2022
View reviewed changes

@tokusumi tokusumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiangolo tiangolo changed the title 🌐 Add Japanese translation for - docs/ja/docs/advanced/websockets.md 🌐 Add Japanese translation for - docs/ja/docs/advanced/websockets.md Jul 14, 2022
@tiangolo tiangolo changed the title 🌐 Add Japanese translation for - docs/ja/docs/advanced/websockets.md 🌐 Add Japanese translation for docs/ja/docs/advanced/websockets.md Jul 14, 2022
@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations awaiting-review labels Jul 14, 2022
@github-actions github-actions Bot mentioned this pull request Jul 14, 2022
Closed
komtaki
komtaki reviewed Nov 7, 2022
View reviewed changes

@komtaki komtaki left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. 👍

Comment thread docs/ja/docs/advanced/websockets.md
Comment thread docs/ja/docs/advanced/websockets.md Outdated
xryuseix and others added 2 commits November 7, 2022 16:53
@xryuseix @komtaki
Apply suggestions from code review
a66a976 
🌐 Add Japanese translation for install section of websocket

Co-authored-by: komtaki <[email protected]>
@xryuseix
Merge branch 'master' into add-ja-translate-advanced-websockets
2ace4d0
@xryuseix

xryuseix commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

レビューありがとうございます。Suggestedしていただいた通りにインストール手順の追加とコンフリクトの修正を行いました。
Thanks for the review, we have added an install section and fixed the conflicts.

@github-actions

github-actions Bot commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 2ace4d0 at: https://6368bb6939a24014a9ea7aaa--fastapi.netlify.app

komtaki
komtaki approved these changes Nov 9, 2022
View reviewed changes

@komtaki komtaki left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!! 👏

LGTM 🚀

@tiangolo

tiangolo commented Nov 13, 2022

Copy link
Copy Markdown
Member

Great, thanks @xryuseix! 🚀

And thanks for the reviews @komtaki and @tokusumi 🍰

@tiangolo tiangolo merged commit 59208e4 into fastapi:master Nov 13, 2022
@xryuseix xryuseix deleted the add-ja-translate-advanced-websockets branch November 13, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@komtaki komtaki komtaki approved these changes

@tokusumi tokusumi tokusumi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xryuseix @tiangolo @komtaki @tokusumi