Thanks to visit codestin.com
Credit goes to github.com

Skip to content

📝 Update Deta deployment tutorial for compatibility with Deta Space#6004

Merged
tiangolo merged 23 commits into
fastapi:masterfrom
sudo-subg:master
May 8, 2023
Merged

📝 Update Deta deployment tutorial for compatibility with Deta Space#6004
tiangolo merged 23 commits into
fastapi:masterfrom
sudo-subg:master

Conversation

@sudo-subg

@sudo-subg sudo-subg commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 0b1015d at: https://63ed3437f56a5a0b8b5107a3--fastapi.netlify.app

@sudo-subg

sudo-subg commented Feb 15, 2023

Copy link
Copy Markdown
Contributor Author

WIP / draft

@Ryandaydev

Ryandaydev commented Feb 19, 2023

Copy link
Copy Markdown

Are there any tests associated with this PR?

@lemonyte lemonyte mentioned this pull request Feb 21, 2023
Merged
@sudo-subg

sudo-subg commented Feb 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Are there any tests associated with this PR?
@Ryandaydev, no. Just an update on how to deploy a FastAPI app on Deta for compatibility with Space

santigandolfo
santigandolfo reviewed Feb 23, 2023
View reviewed changes
Comment thread docs/en/docs/deployment/deta.md Outdated

@app.get("/items/{item_id}")
def read_item(item_id: int):
print({"item_id": item_id})

@santigandolfo santigandolfo Feb 23, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print({"item_id": item_id})
print({"item_id": item_id})

@github-actions

github-actions Bot commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 1338fc5 at: https://63f78a8c1643cf265e41d8e8--fastapi.netlify.app

abdelhai
abdelhai suggested changes Feb 23, 2023
View reviewed changes
Comment thread docs/en/docs/deployment/deta.md Outdated
@app.get("/items/{item_id}")
def read_item(item_id: int):
async def read_item(item_id: int):
print({"item_id": item_id})

@abdelhai abdelhai Feb 23, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would remove

@github-actions

github-actions Bot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit c6052d1 at: https://63fe05f5e66d1b1476d2cae2--fastapi.netlify.app

@github-actions

github-actions Bot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit aaa48cf at: https://63fe1fd1421e2c0d783763a7--fastapi.netlify.app

@github-actions

github-actions Bot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 904b621 at: https://63fe41853295e9147523ff47--fastapi.netlify.app

@github-actions

github-actions Bot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 6cafe99 at: https://63fe739d3295e93fb3240118--fastapi.netlify.app

@github-actions

github-actions Bot commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit fdb61b9 at: https://63fefcb7d08d5446ade7f581--fastapi.netlify.app

@github-actions

github-actions Bot commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 0d65d03 at: https://641aea09031a44054a70c337--fastapi.netlify.app

@github-actions

github-actions Bot commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 1287683 at: https://643955486ac93f00770378d2--fastapi.netlify.app

@tiangolo tiangolo changed the title Updating the Deta deployment tutorial for compatibility with Deta Space 📝 Update Deta deployment tutorial for compatibility with Deta Space May 8, 2023
@github-actions

github-actions Bot commented May 8, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 6bd7fe2 at: https://6458e3861db33321daa14ef6--fastapi.netlify.app

@github-actions

github-actions Bot commented May 8, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 4216a16 at: https://6458ea680554c8318143eb7d--fastapi.netlify.app

@tiangolo

tiangolo commented May 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks @mikBighne98! 🍰

I tweaked the docs a bit, fixed a couple of things, updated a couple others for consistency, renamed the images to keep the old ones for the translations, and fixed the console outputs, this is ready! 🚀

@tiangolo tiangolo merged commit 724060d into fastapi:master May 8, 2023
@sudo-subg

sudo-subg commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for reviewing and merging the PR, @tiangolo 🙂

@lemonyte lemonyte mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@santigandolfo santigandolfo santigandolfo left review comments

@abdelhai abdelhai abdelhai requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sudo-subg @Ryandaydev @tiangolo @abdelhai @santigandolfo @lemonyte @xeust