OpenAPI schema generation: Don't convert all enums into str#906
Merged
Conversation
Before doing this,the type of values in `enum` could be at odds with `type` field.
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
==========================================
- Coverage 100% 99.92% -0.08%
==========================================
Files 293 293
Lines 7692 7701 +9
==========================================
+ Hits 7692 7695 +3
- Misses 0 6 +6
Continue to review full report at Codecov.
|
3 tasks
Member
|
Thanks! Good point 🔍 🚀 I updated it to allow any type as subtype of Thanks for your contribution! 🍰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before doing this,the type of values in
enumcould be at odds withtypefield.