Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Log email-validator not installed only when used #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiangolo merged 2 commits into from
Feb 4, 2020
Merged

Log email-validator not installed only when used #946

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1a8cbe
:mute: Log email-validator not installed only when used
tiangolo Feb 4, 2020
1155006
:art: Fix sort imports
tiangolo Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions fastapi/openapi/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from enum import Enum
from typing import Any, Dict, List, Optional, Union
from typing import Any, Callable, Dict, Iterable, List, Optional, Union

from fastapi.logger import logger
from pydantic import BaseModel
Expand All @@ -21,13 +21,19 @@
# TODO: remove when removing support for Pydantic < 1.0.0
from pydantic.types import EmailStr # type: ignore
except ImportError: # pragma: no cover
logger.info(
"email-validator not installed, email fields will be treated as str.\n"
"To install, run: pip install email-validator"
)

class EmailStr(str): # type: ignore
pass
@classmethod
def __get_validators__(cls) -> Iterable[Callable]:
yield cls.validate

@classmethod
def validate(cls, v: Any) -> str:
logger.warning(
"email-validator not installed, email fields will be treated as str.\n"
"To install, run: pip install email-validator"
)
return str(v)


class Contact(BaseModel):
Expand Down