Codecov Report

Merging #994 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #994   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         294    295    +1     
  Lines        7732   7749   +17     
=====================================
+ Hits         7732   7749   +17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3c9b6...97f464a. Read the comment docs.

@tiangolo looks like something is messed up with the netlify CI for pull requests? I think that might be related to why the codecov didn't hit 100%?

@dmontagu I opened #1023 to fix that.

Thanks @merowinger92 ! Good job! 🚀 🍰

I added a test to very the fix and make sure we avoid regressions.

@dmontagu Yeah, I think the coverage miss was related to 2 versions of Python (3.6 and >=3.7) with the back ports. Not sure why one of them could not have finished, but now they passed.

At the same time, there was the issue with the Netlify deploys 🤦‍♂️ : During the last months I was running out of the free build time allowance and they were already charging me. So, to remove that extra cost I added deploys with GitHub actions, but they can't work with PRs from forks (in the straightforward implementation).

But it's sort of solved now. There's more context about the Netlify deploys here #1046 and here #1047

@peaceiris Thanks! The issue was actually about these deploys not working for PRs from forks, but it's more or less handled in #1046 and #1047 . I'll check your PR later 🙂