docs: modernize python type signature in schemas guide#1573
Open
Evarline wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the configuration docs’ example FastAPI Users schemas to use modern Python union syntax for optional fields.
Changes:
- Replaced
Optional[T]withT | Nonein the documentedUserReadandUserCreateschemas - Updated the documented
UserUpdateschema fields to union syntax and added a default for one field
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+68
to
+69
| first_name: str | None | ||
| birtdate: datetime.date | None = None |
Comment on lines
+68
to
+69
| first_name: str | None | ||
| birtdate: datetime.date | None = None |
Author
|
Solved all the typos and updated the modern optional string syntax with defaults to fix the update schema |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Modern Python type signature
-This pr modernizes the python type signature in the 'schemas.md' configuration guide to use standard pipe operator union types