More automated tests#152
Conversation
…ds the 100% test coverage goal
Uzlopak
left a comment
There was a problem hiding this comment.
basename.test.js should cover all branches
busboy-emit.test.js should check if the first call to busboy.emit('finish') returns anything
dicer-write.test.js does not test what it claims
@Uzlopak am I reading the code wrong, or |
| }) | ||
| }) | ||
|
|
||
| t.end() |
There was a problem hiding this comment.
Basically not testing anything, because you call t.end(). use t.plan for this subtest also.
There was a problem hiding this comment.
@Uzlopak oh, good to know! First time using this testing framework!
There was a problem hiding this comment.
@Uzlopak is there anything else for me to do in this PR?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Added more automated tests, chipping in for the 100% test coverage goal mentioned in here
I really don't know the project, if not for what I studied while writing tests, so I picked the least complicated route and wrote a couple of automated tests of "well exposed" functions and methods