refactor: remove usage of deprecated request.routeConfig#530
Conversation
Uzlopak
left a comment
There was a problem hiding this comment.
Do we have a major release planned?
|
This plugin is now compatible with Fastify 5, where |
|
And does it throw an error if it does an access on that attribute? Or why do you state that this PR ensures compatility with fastify v5? |
|
That fallback is no longer reached. If remove |
|
So the answer to my question regarding "compatibiity" to fastify v5 is no and currently the plugins works without issues in v5. @fastify/plugins |
I made the assessment but I am not really convinced. Its up to you
|
I think we'd just need to do a major if dropping support for Fastify v4, and then updating the compatibility table accordingly. |
|
It looks like this plugin now requires Fastify v5 Lines 542 to 545 in c4185a5 |
Ah, good spot, thanks @inyourtime! Was looking at the compatibility table which was wrong. In that case, happy with this PR! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct