[ci] build: automate messages on released prs#29819
Conversation
lacostej
left a comment
There was a problem hiding this comment.
A couple of small non blocker comments.
| - name: Extract version from artifact | ||
| if: ${{ github.event_name == 'workflow_run' }} | ||
| run: | | ||
| if [ -f "latest.txt" ]; then |
There was a problem hiding this comment.
nitpick: I usually prefer fail fast as it reduces amount of code. Do we have such guidelines ?
There was a problem hiding this comment.
I prefer that too. The earlier iteration had many ifs, but I reworked it then never reduced the logic to fail-fast.
| release_url = github_release['html_url'] | ||
| message = [title, description, release_url].join("\n\n") | ||
| add_fastlane_git_tag(tag: "fastlane/#{version}", message: message) | ||
| File.write("../latest.txt", version) |
There was a problem hiding this comment.
consider adding generated file to .gitignore
| - name: Extract version from artifact | ||
| if: ${{ github.event_name == 'workflow_run' }} | ||
| run: | | ||
| if [ -f "latest.txt" ]; then |
There was a problem hiding this comment.
would latest_fl_version.txt be more self explanatory as a file name?
There was a problem hiding this comment.
Hey @iBotPeaches 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.231.0 🚀
Automation is back!
The messages on merged & released prs.
The Nerdy
When things moved to GitHub Actions
GITHUB_TOKENthose workflows cannot trigger their own workflows to prevent infinite loops. This meant the job that ran after a deploy never ran. If we want to keep a solution that depends on no PAT keys - we have to make changes.Changes
latest_fl_version.txt- this is AFTER gem creation so it is not included in gem file.communicate-on-pull-requested-released.Testing
I heavily tested on my fork until it worked. I can confirm both responses to PRs and issues work.
https://github.com/iBotPeaches/fastlane/actions/runs/20409818600 - the CI
iBotPeaches#14 - test pr
iBotPeaches#15 - test issue
Other