[ci] build: reduce confusion in compilation by renaming things#29826
Conversation
05ad2ab to
088e675
Compare
088e675 to
e26b148
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the build and validation workflow to reduce confusion by:
- Splitting
verify_env_variablesinto two separate functions, separating GitHub credentials from RubyGem credentials - Extracting gem building logic into a dedicated
build_fastlane_gemprivate lane - Continuing the sh() command hardening effort by using separate arguments instead of shell strings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Hey @iBotPeaches 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.231.0 🚀
Reduce Confusion
verify_env_variableschecks for RubyGem creds which isn't needed anymore in GHA flow. I split this out into its own lane calledverify_ruby_gem_credentialsvalidate_repocallsexecute_testswhich builds the gem. This is so confusing. We need a dedicated private lane for building the actual gem file.sh()hardening.