Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[increment_version_number] support MARKETING_VERSION resolving.#30011

Merged
iBotPeaches merged 1 commit into
masterfrom
issue-20132
May 3, 2026
Merged

[increment_version_number] support MARKETING_VERSION resolving.#30011
iBotPeaches merged 1 commit into
masterfrom
issue-20132

Conversation

@iBotPeaches
Copy link
Copy Markdown
Member

Problem

[07:04:32]: Called from Fastfile at line 22
[07:04:32]: ```
[07:04:32]:     20:       lane :bump do
[07:04:32]:     21:         skip_docs
[07:04:32]:  => 22:         increment_version_number
[07:04:32]:     23:       end
[07:04:32]:     24:     end
[07:04:32]: ```
[07:04:32]: Your current version ($(MARKETING_VERSION)) does not respect the format A or A.B or A.B.C

This is because plist is

	<key>CFBundleShortVersionString</key>
	<string>$(MARKETING_VERSION)</string>

Solution

If we detect MARKETING_VERSION we call out to GetVersionNumberAction which reads the .xcodeproj in order to find it. Then we continue as-is to replace the value in the info.plist. Perfect for CI pipelines.

fixes: #20132

@iBotPeaches iBotPeaches merged commit 7549fdf into master May 3, 2026
14 checks passed
@iBotPeaches iBotPeaches deleted the issue-20132 branch May 3, 2026 13:05
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iBotPeaches 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.234.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

increment_version_number fails to update MARKETING_VERSION

2 participants