-
Notifications
You must be signed in to change notification settings - Fork 53
fpl tests #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can just keep it to make sure accessing graphics within a gridplot works etc.
data = np.load("../data/random.npy") | ||
|
||
iw.show() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you test before and after setting timepoint?
set timepoint using the slider as well as @current_index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to think some more about testing image widget, somehow need renderer and canvas to be offscreen as in the other examples
sine = np.load("../data/sine.npy") | ||
cosine = np.load("../data/cosine.npy") | ||
sinc = np.load("../data/sinc.npy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just make these, don't save them since it's not randomly generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I didn't save them was when I kept getting errors locally about the data changing...idk what the precision is like when you call np.sin()
or np.cos()
on a linspace but I think this is what was causing the problem before and that is why I saved them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if you force float32
when making the linspace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will try
it's not working just through pytest because:
data_path = Path(__file__).parent.parent.joinpath("data", "random.npy")
data = np.load(data_path) |
Seems like zenodo is still the best place to store these, ah well. The file will be small at least so download time should be very fast. |
superseeded by #179 |
refactored so there are no large binary files
did reorg for names
#152