-
Notifications
You must be signed in to change notification settings - Fork 53
restarted tests, now work from the command line #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kushalkolar
requested changes
Apr 20, 2023
|
kushalkolar
requested changes
Apr 28, 2023
kushalkolar
requested changes
Apr 28, 2023
added the fancy indexing as mentioned in comments, but I left it commented out for now bc my branch is so far behind master...sent you slack ab it |
use pygfx before pylinalg refactor
sed to remove pygfx from setup.py
imageio
We kinda don't need the "just build" test. Can you make a matrix for the test examples for python versions: https://github.com/pygfx/pygfx/blob/main/.github/workflows/ci.yml#L67-L76 and update the checklist |
testing upload screens
yay! CI pipeline...I think |
amazing job :D @clewis7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #152