selector garbage collection, use selection feature name, cleanup event handlers
#209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's also throw in #211 |
selection feature name, cleanup event handlers
kushalkolar
reviewed
May 26, 2023
| @@ -254,6 +259,9 @@ def cleanup_array_slice(key: np.ndarray, upper_bound) -> np.ndarray: | |||
| if key.dtype == bool: | |||
| key = np.nonzero(key)[0] | |||
|
|
|||
| if key.size < 1: | |||
There was a problem hiding this comment.
@clewis7 can you jog my memory? Is this when you do something like line_graphic.colors[xs > 0] = "w", but xs > 0 is an empty array?
There was a problem hiding this comment.
yes, bc we kept getting an error when trying to set the colors and a behavior had not a occurred so the array was all zeroes, would never give True
| @@ -11,6 +11,9 @@ | |||
|
|
|||
|
|
|||
| class LinearBoundsFeature(GraphicFeature): | |||
| feature_events = ( | |||
| "data", | |||
There was a problem hiding this comment.
this is supposed to be bounds, but as for #211 let's rename it to selection
|
this got included in #207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.