-
Notifications
You must be signed in to change notification settings - Fork 53
Use pyproject.toml (superseded) #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Grrr, I thought I had done |
Sure! I need to go through the codebase and my pycharm and decide how we want to configure ruff, I don't think there's a way to download the rules I'm currently ignoring in pycharm. flake8 is too strict sometimes so we ignore a bunch of things. |
So the deploy docs failure is because the secrets are only in the org. If you set your remote origin to |
I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged? |
We can still see if the docs build step succeeded, but uploading to the server (to see the preview) requires the secrets so we skip it for external contributors for now until we figure out a better way. |
Superseded by #782 |
In future PRs I can do:
_version.py
mechanism as pygfx/wgpu, that e.g. includes nr of commits since last version-tag.