Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use pyproject.toml (superseded) #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

almarklein
Copy link
Collaborator

In future PRs I can do:

  • use same _version.py mechanism as pygfx/wgpu, that e.g. includes nr of commits since last version-tag.
  • Formatting and linting with ruff, perhaps?

@almarklein
Copy link
Collaborator Author

Grrr, I thought I had done git pull but that failed, so this is a bit behind :)

@kushalkolar
Copy link
Member

  • use same _version.py mechanism as pygfx/wgpu, that e.g. includes nr of commits since last version-tag.
  • Formatting and linting with ruff, perhaps?

Sure! I need to go through the codebase and my pycharm and decide how we want to configure ruff, I don't think there's a way to download the rules I'm currently ignoring in pycharm. flake8 is too strict sometimes so we ignore a bunch of things.

@kushalkolar
Copy link
Member

So the deploy docs failure is because the secrets are only in the org. If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

@almarklein
Copy link
Collaborator Author

If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged?

@kushalkolar
Copy link
Member

kushalkolar commented Mar 29, 2025

If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged?

We can still see if the docs build step succeeded, but uploading to the server (to see the preview) requires the secrets so we skip it for external contributors for now until we figure out a better way.

@almarklein almarklein mentioned this pull request Mar 29, 2025
@almarklein
Copy link
Collaborator Author

Superseded by #782

@almarklein almarklein closed this Mar 29, 2025
@almarklein almarklein changed the title Use pyproject.toml Use pyproject.toml (superseded) Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants