Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for reference spaces, implements ideas from #772
I think I want to rename it to reference frame since that's what physicist and math people are used to, I wanted to avoid confusion with the
Frame
class which is something else completely butFrame
is something a user would never touch so.There are two sine waves here but the red one is 3 orders or magnitude larger. The magenta y-axis indicates the values for the red sine data which ranges from [-1000, 1000] and the white axis ticks are for the white sine line which ranges from [-1, 1]
rs-2025-05-01_23.37.11.mp4
By removing the camera from a reference space's controller we can also interactively independently rescale a given reference frame! Will need quite some work to do this properly, have methods to re-sync positions or other things between reference frames etc.