Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove Graphic.share_property() and unshare_property() #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

remove Graphic.share_property() and unshare_property() #842

merged 2 commits into from
Jun 2, 2025

Conversation

kushalkolar
Copy link
Member

This really isn't required and brings in unnecessary complexity which is difficult to test. Sharing a buffer is easy, but toggling between the two can become messy. The docs already cover how to share a buffer:

# add a line
line_graphic = figure[0, 0].add_line(data)

# add a scatter, share the line graphic buffer!
scatter_graphic = figure[0, 0].add_scatter(data=line_graphic.data, sizes=25, colors="r")

@kushalkolar kushalkolar requested a review from clewis7 as a code owner May 28, 2025 19:48
@github-actions GitHub Actions
Copy link

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/remove-share-property

@kushalkolar
Copy link
Member Author

@clewis7 ready for review

@clewis7 clewis7 merged commit 15ab65f into main Jun 2, 2025
95 of 102 checks passed
@clewis7 clewis7 deleted the remove-share-property branch June 2, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clewis7 clewis7 clewis7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kushalkolar @clewis7