add proxy name label to the proxy_count prometheus metric #4985
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
… break existing queries
charlieblevins
commented
Sep 22, 2025
fatedier
reviewed
Sep 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a more detailed Prometheus metric for proxy counting that includes the proxy name as a label. This enables monitoring of individual proxy connections rather than just aggregate counts by type.
- Introduces a new
proxy_counts_detailedmetric with both proxy type and name labels - Updates the
NewProxyandCloseProxymethods to track individual proxy instances - Registers the new metric with the Prometheus registry
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
fatedier
approved these changes
Sep 22, 2025
nebulabox
added a commit
to nebulabox/frp
that referenced
this pull request
Oct 17, 2025
* commit 'ee3cc4b14ea2f8c9581fa06b7151593b94f4ddcc': Fix CloseNotifyConn.Close function (fatedier#5022) update README (fatedier#5001) bump version to v0.65.0 and update release notes (fatedier#4998) update sponsors info (fatedier#4997) chore: fix struct field name in comment (fatedier#4993) auth: enhance OIDC client with TLS and proxy configuration options (fatedier#4990) add proxy name label to the proxy_count prometheus metric (fatedier#4985) update go version to 1.24 (fatedier#4960) update README (fatedier#4957) improve yamux logging (fatedier#4952) xtcp: add configuration to disable assisted addresses in NAT traversal (fatedier#4951) remove quotes (fatedier#4938) Merge pull request fatedier#4928 from fatedier/xtcp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
In my use case, I have many different frpc binaries connecting to the same frps binary. Each frpc binary has a unique proxy name configured.
For this reason, it is useful to know which proxy (i.e. worker/control connection) is active. Without this PR, I can only know how many proxies are connected, but not which ones.
Fix #4986